Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MSHADE-366] "Access denied" during 'minimizeJar' #161

Merged
merged 4 commits into from Oct 20, 2022
Merged

[MSHADE-366] "Access denied" during 'minimizeJar' #161

merged 4 commits into from Oct 20, 2022

Commits on Oct 20, 2022

  1. [MSHADE-366] - "Access denied" during 'minimizeJar' 

    Now ignoring directories when scanning the classpath for services.
    @JanMosigItemis @gnodet
    JanMosigItemis authored and gnodet committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    71c7a82 View commit details
    Browse the repository at this point in the history

  2. [MSHADE-366] Refactor fix by @JanMosigItemis from apache#83 

    - Simplify Jan's solution from apache#83 in order to use 'continue' instead of
  nested 'if-else'.
- Factor out two helper methods from 'removeServices', because that
  method was way too big to still be readable.
- DRY-refactor Jan's new test cases into one checking two conditions.
    @kriegaex @gnodet
    kriegaex authored and gnodet committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    6bf6662 View commit details
    Browse the repository at this point in the history

  3. Another attempt to clarify the problem 

    - do not ignore directories, print a warning as before
- ignore the project's build output directory which is always returned by getRuntimeClassPathElements()
    @gnodet
    gnodet committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    ed8ec8e View commit details
    Browse the repository at this point in the history

  4. Fix the test to work on all platforms, irrespective of the actual exc… 

    …eption sent by the JDK
    @gnodet
    gnodet committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    5213c6b View commit details
    Browse the repository at this point in the history