[MSHADE-366] "Access denied" during 'minimizeJar' #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now ignoring directories when scanning the classpath for services.
- Simplify Jan's solution from apache#83 in order to use 'continue' instead of nested 'if-else'. - Factor out two helper methods from 'removeServices', because that method was way too big to still be readable. - DRY-refactor Jan's new test cases into one checking two conditions.
- do not ignore directories, print a warning as before - ignore the project's build output directory which is always returned by getRuntimeClassPathElements()
melloware
approved these changes
Oct 20, 2022
…eption sent by the JDK
rmannibucau
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #104 and #83.
JIRA: https://issues.apache.org/jira/browse/MSHADE-366
The fact that the build output directory has to be handled is legit because the minifier calls
project.getRuntimeClassPathElements()which returns a list of the project output dir and all dependencies jars. It has to be handled specifically. Any other directory will print a warning as currently.It could be considered to switch the call to
project.getRuntimeClassPathElements()to another call but that seems out of scope for this bug fix PR.