Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize build #150

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Optimize build #150

wants to merge 2 commits into from

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Feb 4, 2022

The goal is that a subsequent maven build will not touch the jars at all. In order to achieve that, the manifest is build in a separate directory and moved (with filtering) into the target/classes folder.

The goal is that a subsequent maven build will not touch the jars at all.  In order to achieve that, the manifest is build in a separate directory and moved (with filtering) into the target/classes folder.
@gnodet gnodet marked this pull request as draft February 7, 2022 10:02
@gnodet
Copy link
Contributor Author

gnodet commented Feb 8, 2022

This should be update to maven-compiler-plugin 3.10.0 which should be released soon.

@cstamas
Copy link
Member

cstamas commented Apr 25, 2022

This redefines bnd plugin, latest updates was to 6.2.0 but you added 6.1.0?

1 similar comment
@cstamas
Copy link
Member

cstamas commented Apr 25, 2022

This redefines bnd plugin, latest updates was to 6.2.0 but you added 6.1.0?

@gnodet
Copy link
Contributor Author

gnodet commented Apr 25, 2022

This redefines bnd plugin, latest updates was to 6.2.0 but you added 6.1.0?

The upgrade to 6.2.0 was done 2 days ago, while my upgrade to 6.1.0 was 2 months ago.
Anyway, I have some pending changes for this PR, but this will depend on apache/maven-plugin-tools#67 and codehaus-plexus/plexus-utils#184. I'll have another look at this last PR to investigate the failing test.

@gnodet
Copy link
Contributor Author

gnodet commented Apr 25, 2022

This redefines bnd plugin, latest updates was to 6.2.0 but you added 6.1.0?

The upgrade to 6.2.0 was done 2 days ago, while my upgrade to 6.1.0 was 2 months ago. Anyway, I have some pending changes for this PR, but this will depend on apache/maven-plugin-tools#67 and codehaus-plexus/plexus-utils#184. I'll have another look at this last PR to investigate the failing test.

So @cstamas feel free to review codehaus-plexus/plexus-utils#184 which I've just fixed !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants