update plexus-utils to 4.0.0 #59
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would abstain to merge this for now |
slachiewicz
reviewed
Oct 22, 2023
| <dependency> | ||
| <groupId>org.codehaus.plexus</groupId> | ||
| <artifactId>plexus-xml</artifactId> | ||
| <version>4.0.0</version> |
There was a problem hiding this comment.
Why actually? This piece of information should be documented somewhere...
There was a problem hiding this comment.
There was a problem hiding this comment.
I see, then this needs to be checked with all components updated to 40.
There was a problem hiding this comment.
Yes I'm reviewing it. Dependabot helps with notification here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pushing this one up to see what happens and what people think. I'm not confident in it though. The split of plexus-utils and plexus-xml in 4.0.0 risks split package problems in Java 9+:
https://jlbp.dev/JLBP-19