Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-6825] Replace StringUtils with Commons Lang3 #120

Conversation

timtebeek
Copy link
Contributor

No description provided.

Co-authored-by: Moderne <team@moderne.io>
@elharo
Copy link
Contributor

elharo commented Apr 4, 2023

The failing build is likely broken already. I'm looking into it.

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase. The failing CI should now pass, and then we'll be good to go.

@timtebeek
Copy link
Contributor Author

Resolved the conflicts, but I assume we'll want to first remove the StringUtils.is(Not)Empty/Blank, which will likely result in unused imports here.

@elharo
Copy link
Contributor

elharo commented Apr 8, 2023

I don't think we have to remove StringUtils.is(Not)Empty/Blank first, though it's fine if someone wants to do that.

@timtebeek
Copy link
Contributor Author

Looks like we'll move away from commons-lang3 instead; https://issues.apache.org/jira/browse/MNG-6829
Closing this one in favor of changes such as replacing StringUtils.isEmpty/isNotEmpty with JDK internals.

@timtebeek timtebeek closed this Apr 18, 2023
@timtebeek timtebeek deleted the refactor/mng-6825-replace-string-utils-with-commons-lang-3 branch April 18, 2023 10:13
@elharo
Copy link
Contributor

elharo commented Apr 18, 2023

JDK > commons-lang3 > maven-shared-utils > plexus-utils

If we can go straight to JDK only, wonderful, but I'd still approve a PR that replaces plexus with commons lang.

@timtebeek timtebeek restored the refactor/mng-6825-replace-string-utils-with-commons-lang-3 branch April 18, 2023 11:58
@timtebeek
Copy link
Contributor Author

Would you like to see this recreated now that we have 40fe444 merged in? It'd swap even fewer imports, with no new dependency as commons-lang3 is already a dependency.

maven-pmd-plugin/pom.xml

Lines 148 to 150 in 40fe444

<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
<version>3.12.0</version>

@elharo
Copy link
Contributor

elharo commented Apr 20, 2023

sure, if this is still relevant, do it

@timtebeek timtebeek deleted the refactor/mng-6825-replace-string-utils-with-commons-lang-3 branch May 14, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants