[MPMD-342] No debug log message issued when empty report shall be ski…

…pped and not issues have been found This closes #69
apache · May 15, 2022 · 6b7c642 · 6b7c642
1 parent 7467798
commit 6b7c642
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/main/java/org/apache/maven/plugins/pmd/CpdReport.java b/src/main/java/org/apache/maven/plugins/pmd/CpdReport.java
@@ -185,7 +185,7 @@ public boolean canGenerateReport()
                 if ( skipEmptyReport )
                 {
                     result = cpdResult.hasDuplications();
-                    if ( result )
+                    if ( !result )
                     {
                         getLog().debug( "Skipping report since skipEmptyReport is true and there are no CPD issues." );
                     }
@@ -232,11 +232,11 @@ private void executeCpd()
             request.setLanguageProperties( languageProperties );
             request.setSourceEncoding( determineEncoding( !filesToProcess.isEmpty() ) );
             request.addFiles( filesToProcess.keySet() );
-            
+
             request.setShowPmdLog( showPmdLog );
             request.setColorizedLog( MessageUtils.isColorEnabled() );
             request.setLogLevel( determineCurrentRootLogLevel() );
-            
+
             request.setExcludeFromFailureFile( excludeFromFailureFile );
             request.setTargetDirectory( targetDirectory.getAbsolutePath() );
             request.setOutputEncoding( getOutputEncoding() );

diff --git a/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java
@@ -337,7 +337,7 @@ public boolean canGenerateReport()
                 if ( skipEmptyReport )
                 {
                     result = pmdResult.hasViolations();
-                    if ( result )
+                    if ( !result )
                     {
                         getLog().debug( "Skipping report since skipEmptyReport is true and "
                                             + "there are no PMD violations." );