[MPLUGIN-457] Use Resolver API, get rid of localRepository #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
requested changes
Apr 15, 2023
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java
Outdated
Show resolved
Hide resolved
.../apache/maven/tools/plugin/extractor/annotations/JavaAnnotationsMojoDescriptorExtractor.java
Outdated
Show resolved
Hide resolved
.../apache/maven/tools/plugin/extractor/annotations/JavaAnnotationsMojoDescriptorExtractor.java
Show resolved
Hide resolved
.../apache/maven/tools/plugin/extractor/annotations/JavaAnnotationsMojoDescriptorExtractor.java
Outdated
Show resolved
Hide resolved
...-plugin-tools-api/src/main/java/org/apache/maven/tools/plugin/DefaultPluginToolsRequest.java
Show resolved
Hide resolved
kwin
reviewed
Apr 15, 2023
.../apache/maven/tools/plugin/extractor/annotations/JavaAnnotationsMojoDescriptorExtractor.java
Outdated
Show resolved
Hide resolved
slawekjaranowski
force-pushed
the
MPLUGIN-457
branch
from
86bd77e
to
44d0877
Compare
michael-o
requested changes
Apr 15, 2023
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java
Show resolved
Hide resolved
.../apache/maven/tools/plugin/extractor/annotations/JavaAnnotationsMojoDescriptorExtractor.java
Outdated
Show resolved
Hide resolved
slawekjaranowski
force-pushed
the
MPLUGIN-457
branch
from
44d0877
to
121b4ec
Compare
michael-o
requested changes
Apr 15, 2023
.../apache/maven/tools/plugin/extractor/annotations/JavaAnnotationsMojoDescriptorExtractor.java
Outdated
Show resolved
Hide resolved
slawekjaranowski
force-pushed
the
MPLUGIN-457
branch
from
121b4ec
to
cc8d980
Compare
kwin
approved these changes
Apr 15, 2023
michael-o
requested changes
Apr 15, 2023
.../apache/maven/tools/plugin/extractor/annotations/JavaAnnotationsMojoDescriptorExtractor.java
Outdated
Show resolved
Hide resolved
slawekjaranowski
force-pushed
the
MPLUGIN-457
branch
from
cc8d980
to
064b436
Compare
michael-o
approved these changes
Apr 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.