Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MJAVADOC-721] Parse stderr output and suppress informational lines #157

Merged
merged 1 commit into from
Sep 2, 2022
Merged

[MJAVADOC-721] Parse stderr output and suppress informational lines #157

merged 1 commit into from
Sep 2, 2022

Conversation

spannm
Copy link

@spannm spannm commented Jul 26, 2022

This PR offers a solution for ticket MJAVADOC-721. Please refer to the ticket for details. Thanks.

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MJAVADOC-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify -Prun-its to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@spannm
Copy link
Author

spannm commented Aug 12, 2022

Hello maintainers,
could someone approve the workflow and give feedback to this pr?

@spannm
Copy link
Author

spannm commented Aug 29, 2022

hello hello

@spannm
Copy link
Author

spannm commented Aug 29, 2022

Rebased to master.

Hi @michael-o as you were the one to release the latest version of the plugin, I was wondering if you would take a look at my PR?

@spannm
Copy link
Author

spannm commented Sep 1, 2022

Good morning @michael-o,
are you willing to merge this pr or are there ToDos left for me?

@michael-o michael-o self-requested a review September 2, 2022 07:42
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build and compared output. Muss less noise. Nice change.

@asfgit asfgit merged commit 139af8c into apache:master Sep 2, 2022
@spannm
Copy link
Author

spannm commented Sep 2, 2022

Build and compared output. Muss less noise. Nice change.

Thanks! I look forward to this feature in the next release. It was great working together @michael-o

@spannm spannm deleted the sman-81-MJAVADOC-721 branch September 2, 2022 10:04
@michael-o
Copy link
Member

Build and compared output. Muss less noise. Nice change.

Thanks! I look forward to this feature in the next release. It was great working together @michael-o

Sure, I always appreciate high quality, straightforward patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants