Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MJAVADOC-538] Filter out 'Picked up' #11

Merged
merged 1 commit into from Nov 19, 2018

Conversation

risdenk
Copy link
Contributor

@risdenk risdenk commented Nov 13, 2018

Tested with:

  • mvn -Prun-its verify

Additional testing on project I was having original issues

  • mvn install
  • export JAVA_TOOL_OPTIONS="-Dapple.awt.UIElement=true"
  • Set pom for project to use 3.0.2-SNAPSHOT
<pluginManagement>
  <plugins>
    <plugin>
      <groupId>org.apache.maven.plugins</groupId>
      <artifactId>maven-javadoc-plugin</artifactId>
      <version>3.0.2-SNAPSHOT</version>
    </plugin>
  </plugins>
</pluginManagement>
  • Ran the following on my project - mvn -Dmaven.javadoc.failOnError=true -Dmaven.javadoc.failOnWarnings=true javadoc:javadoc javadoc:test-javadoc

Prior to this change was getting failure from warning "Picked up ...". With this change, Javadoc no longer fails due to warning.

@yrodiere
Copy link

FWIW, I can confirm this solves the problem in my project. Thanks!

@risdenk
Copy link
Contributor Author

risdenk commented Nov 18, 2018

Added integration test.

Copy link
Contributor

@rfscholte rfscholte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small things to improve, almost there.

pom.xml Show resolved Hide resolved
src/it/projects/MJAVADOC-538/pom.xml Show resolved Hide resolved
src/it/projects/MJAVADOC-538/invoker.properties Outdated Show resolved Hide resolved
src/it/projects/MJAVADOC-538/pom.xml Show resolved Hide resolved
@risdenk
Copy link
Contributor Author

risdenk commented Nov 19, 2018

@rfscholte Addressed your review comments. Thanks!

@rfscholte
Copy link
Contributor

One final request: add yourself as contributor to the root pom.xml if you want.

Signed-off-by: Kevin Risden <krisden@apache.org>
@risdenk
Copy link
Contributor Author

risdenk commented Nov 19, 2018

@rfscholte added myself as contributor. Let me know if there is anything else :)

@rfscholte
Copy link
Contributor

https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven-javadoc-plugin/job/MJAVADOC-538/
I need to figure out what's wrong with Windows + Java 7 before merging (looks unrelated to this commit)

@rfscholte rfscholte merged commit 631a84e into apache:master Nov 19, 2018
@risdenk risdenk deleted the MJAVADOC-538 branch December 6, 2018 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants