Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code simplifications in AbstractMojo #47

Merged
merged 4 commits into from Aug 14, 2022
Merged

Code simplifications in AbstractMojo #47

merged 4 commits into from Aug 14, 2022

Commits on Aug 11, 2022

  1. Replace StringBuilder with string concatenation in AbstractJarMojo#ge… 

    …tJarFile
    @rhowe
    rhowe committed Aug 11, 2022
    Copy the full SHA
    61f7352 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2022

  1. Simplify archiver selection

    @rhowe
    rhowe committed Aug 13, 2022
    Copy the full SHA
    9e9ab0a View commit details
    Browse the repository at this point in the history

  2. Simplify projectHasAlreadySetAnArtifact in AbstractJarMojo 

    Inverting this test leads to a more readable flow.
    @rhowe
    rhowe committed Aug 13, 2022
    Copy the full SHA
    d26c272 View commit details
    Browse the repository at this point in the history

  3. Simplify hasClassifier 

    We can remove all branching from this method and return the check
directly.
    @rhowe
    rhowe committed Aug 13, 2022
    Copy the full SHA
    611bc67 View commit details
    Browse the repository at this point in the history