Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MJAR-278] Update plugin (requires Maven 3.2.5+) #19

Merged
merged 7 commits into from Jul 2, 2022
Merged

[MJAR-278] Update plugin (requires Maven 3.2.5+) #19

merged 7 commits into from Jul 2, 2022

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Oct 11, 2021 •
edited

Bump to Java 8. Make mvn core bits
proper scoped.

https://issues.apache.org/jira/browse/MJAR-278

@cstamas
Update plugin
21716f5 
And retain it still Java7. Make mvn core bits
proper scoped.
elharo
elharo reviewed Oct 11, 2021
View reviewed changes
pom.xml
<mavenArchiverVersion>3.5.0</mavenArchiverVersion>
<mavenVersion>3.1.0</mavenVersion>
<mavenArchiverVersion>3.5.1</mavenArchiverVersion>
<mavenVersion>3.2.5</mavenVersion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as on war. Is the projct ready to drop 3.1.1 support?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is requirement dictated by maven-plugin-testing-harness v 3.3.0

@cstamas cstamas self-assigned this Oct 13, 2021
@cstamas cstamas marked this pull request as draft October 13, 2021 20:54
@cstamas cstamas changed the title Update plugin [MJAR-278] Update plugin (requires Maven 3.2.5+) Oct 15, 2021
@cstamas cstamas marked this pull request as ready for review October 15, 2021 12:17
jorsol
jorsol approved these changes Apr 9, 2022
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@cstamas
Copy link
Member Author

cstamas commented Apr 14, 2022

Any idea about failing IT manifest-content?

@slawekjaranowski
Copy link
Member

Any idea about failing IT manifest-content?

Try rebase, see #40

jorsol
jorsol reviewed Jun 17, 2022
View reviewed changes
Copy link
Contributor

@jorsol jorsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be rebased with master

pom.xml Outdated
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-archiver</artifactId>
<version>4.2.5</version>
Copy link
Contributor

@jorsol jorsol Jun 17, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be needed since when the maven-archiver 3.6.0 is released (#43) it will update plexus-archiver to 4.3.0, so the explicit dependency should not be added.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I have to, as am dropping m-shared-utils... so IMHO once this merged you should add your PR on top of it. W/o this change, due drop of m-shared-utils the build would fail 😞

@cstamas
Copy link
Member Author

cstamas commented Jun 27, 2022

Depends on apache/maven-file-management#11

michael-o
michael-o approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until File Management 3.1.0 is released.

pom.xml Outdated Show resolved Hide resolved
@michael-o
Copy link
Member

I see these:

[INFO] --- maven-dependency-plugin:3.3.0:analyze (default-cli) @ maven-jar-plugin ---
[WARNING] Unused declared dependencies found:
[WARNING]    org.apache.maven:maven-model:jar:3.2.5:provided
[WARNING]    org.codehaus.plexus:plexus-utils:jar:3.4.2:runtime

I think at least Plexus Utils can go away, no?

@cstamas
Copy link
Member Author

cstamas commented Jul 2, 2022

Jenkins windows node failure (post build, build is OK): clean workspace

@cstamas cstamas merged commit c02be20 into master Jul 2, 2022
@cstamas cstamas deleted the update-plugin branch July 2, 2022 09:16
@cstamas cstamas mentioned this pull request Jul 2, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo left review comments

@jorsol jorsol jorsol approved these changes

@khmarbaise khmarbaise khmarbaise approved these changes

@michael-o michael-o michael-o approved these changes

@bmarwell bmarwell bmarwell approved these changes

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

@slachiewicz slachiewicz slachiewicz approved these changes

@rfscholte rfscholte Awaiting requested review from rfscholte

Assignees

@cstamas cstamas

Labels
enhancement
Projects
None yet
Milestone
No milestone
8 participants
@cstamas @slawekjaranowski @michael-o @khmarbaise @elharo @bmarwell @jorsol @slachiewicz