Simplify projectHasAlreadySetAnArtifact in AbstractJarMojo

Inverting this test leads to a more readable flow.
apache · Aug 11, 2022 · 4d02802 · 4d02802
1 parent 36d794f
commit 4d02802
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java b/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
@@ -322,14 +322,12 @@ public void execute()
 
     private boolean projectHasAlreadySetAnArtifact()
     {
-        if ( getProject().getArtifact().getFile() != null )
-        {
-            return getProject().getArtifact().getFile().isFile();
-        }
-        else
+        if ( getProject().getArtifact().getFile() == null )
         {
             return false;
         }
+
+        return getProject().getArtifact().getFile().isFile();
     }
 
     /**