Batch update to plugin #207
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <compilerArgs> | ||
| <compilerArg>-Xlint:deprecation</compilerArg> | ||
| </compilerArgs> |
There was a problem hiding this comment.
We have a param showDeprecation for m-compiler-p
Comment on lines
+65
to
+66
| <mavenMinVersion>3.2.5</mavenMinVersion> | ||
| <mavenVersion>3.9.6</mavenVersion> |
There was a problem hiding this comment.
I'm not still sure about such way.
We open way to use newer API/methods in plugin which can be only detected in runtime.
I'm for switch to 3.6.3 as minimal and in dependency
There was a problem hiding this comment.
I wouldn't do this either in this release.
michael-o
requested changes
Jan 1, 2024
Comment on lines
+65
to
+66
| <mavenMinVersion>3.2.5</mavenMinVersion> | ||
| <mavenVersion>3.9.6</mavenVersion> |
There was a problem hiding this comment.
I wouldn't do this either in this release.
| <groupId>org.apache.maven.resolver</groupId> | ||
| <artifactId>maven-resolver-api</artifactId> | ||
| <version>1.9.18</version> | ||
| <scope>provided</scope> |
There was a problem hiding this comment.
This does not correspond to the approach we have taken in other plugins: Use the same Resolver API version as with the base Maven Core version.
| <groupId>org.codehaus.plexus</groupId> | ||
| <artifactId>plexus-container-default</artifactId> | ||
| </exclusion> | ||
| </exclusions> |
There was a problem hiding this comment.
Fair enough, will be solved with Doxia 2.0.0.
Update dependencies and sort out resolver-util.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update parent POM, dependencies and
sort out resolver-util.