Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINVOKER-306] - Fixed bug if only exclude-patterns specified #135

Merged
merged 1 commit into from Jul 29, 2022

Conversation

bvfalcon
Copy link
Contributor

@bvfalcon bvfalcon commented Jul 26, 2022

In addition to MINVOKER-140: exclude patterns works only if one or more include pattern(s) exists. This is a feature of plexus-utils Component DirectoryScanner.

So, in our case command line parameter -Dinvoker.test=!testX (and configuration parameter invokerTest ) works absolutely different way: all projects (not only testX) will be skipped. We must use -Dinvoker.test=*,!testX or -Dinvoker.test=!testX,* as workarround.

In this commit I add forced additional include pattern "*" as default include pattern for cases, when invoker.test contains only exclude-patterns. User still use -Dinvoker.test=!testX and all will work correctly for him. The change is full back-compatibile with current plugin settings.

Integration test invocation-cmdline-exclude is actualized, JIRA Ticket created: MINVOKER-306.

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.

  • Each commit in the pull request should have a meaningful subject line and body.

  • Format the pull request title like [MINVOKER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MINVOKER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.

  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.

  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.

  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We change some of logic - please create new issue with description, examples and justifications

@bvfalcon
Copy link
Contributor Author

We change some of logic - please create new issue with description, examples and justifications

This PR is only bugfix, it contains nothing new. Logic is the same - "all except testX", but syntax -Dinvoker.test=!testX not works and syntax -Dinvoker.test=*,!testX not so obvious.

@slawekjaranowski
Copy link
Member

You are right it is a bug.
Thanks for your efforts.

We need issues for tracking - what next release will contains.

You also remove default PR template, which contains some of formal information about contributing license - please restore at lest such information.

@bvfalcon bvfalcon changed the title MINVOKER-140: additional note MINVOKER-140 - Fixed bug if only exclude-patterns specified Jul 26, 2022
@bvfalcon bvfalcon changed the title MINVOKER-140 - Fixed bug if only exclude-patterns specified MINVOKER-306 - Fixed bug if only exclude-patterns specified Jul 26, 2022
@bvfalcon
Copy link
Contributor Author

Done. Jira ticket created - MINVOKER-306 and pull request description modified to standard view

@bvfalcon bvfalcon closed this Jul 27, 2022
@bvfalcon bvfalcon deleted the MINVOKER-140 branch July 27, 2022 08:04
@bvfalcon bvfalcon restored the MINVOKER-140 branch July 27, 2022 08:06
@bvfalcon bvfalcon reopened this Jul 27, 2022
@slawekjaranowski slawekjaranowski self-assigned this Jul 27, 2022
@slawekjaranowski slawekjaranowski changed the title MINVOKER-306 - Fixed bug if only exclude-patterns specified [MINVOKER-306] - Fixed bug if only exclude-patterns specified Jul 28, 2022
@slawekjaranowski slawekjaranowski merged commit c07ca87 into apache:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants