[MINVOKER-306] - Fixed bug if only exclude-patterns specified #135
+81
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to MINVOKER-140: exclude patterns works only if one or more include pattern(s) exists. This is a feature of plexus-utils Component DirectoryScanner.
So, in our case command line parameter
-Dinvoker.test=!testX
(and configuration parameter invokerTest ) works absolutely different way: all projects (not only testX) will be skipped. We must use-Dinvoker.test=*,!testX
or-Dinvoker.test=!testX,*
as workarround.In this commit I add forced additional include pattern "*" as default include pattern for cases, when invoker.test contains only exclude-patterns. User still use
-Dinvoker.test=!testX
and all will work correctly for him. The change is full back-compatibile with current plugin settings.Integration test invocation-cmdline-exclude is actualized, JIRA Ticket created: MINVOKER-306.
Following this checklist to help us incorporate your contribution quickly and easily:
Make sure there is a JIRA issue filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
Each commit in the pull request should have a meaningful subject line and body.
Format the pull request title like
[MINVOKER-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MINVOKER-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Run
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
You have run the integration tests successfully (
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.