Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINSTALL-164] - Create GitHub Actions #9

Merged
merged 1 commit into from Oct 7, 2021
Merged

[MINSTALL-164] - Create GitHub Actions #9

merged 1 commit into from Oct 7, 2021

Conversation

bmarwell
Copy link
Contributor

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MINSTALL-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MINSTALL-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Copy link
Member

@cstamas cstamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls merge

@cstamas
Copy link
Member

cstamas commented Oct 7, 2021

Pls pls merge

Copy link
Member

@aheritier aheritier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why it is useful in comparison of the official build env but why not ...

@cstamas
Copy link
Member

cstamas commented Oct 7, 2021

@aheritier ASF Jenkins is still the "source of truth", OTOH GH Actions:

  • gives amazingly fast builds (well, off US office hours at least)
  • gives feedback about "full build" here, on this very page (makes easier to spot what to review what not)
  • has up to date Java versions (Jenkins lags), has macOS builds (Jenkins has not)

All in all, is great help for reviewers but also for PR submitter....

(all this IF action covers ITs etc... as many maven projects does not run ITs in GH action yet, about to clean up)

@bmarwell bmarwell merged commit bd869da into master Oct 7, 2021
@bmarwell bmarwell deleted the MINSTALL-164 branch October 7, 2021 13:27
@bmarwell
Copy link
Contributor Author

bmarwell commented Oct 7, 2021

@cstamas done.

Do we want to update the JDKs?
Do you need additional JDKs (like OpenJ9)?

@slawekjaranowski
Copy link
Member

And I see it is another way for GA ... here be using build in containers ...

@cstamas
Copy link
Member

cstamas commented Oct 7, 2021

Cool, thanks!

@slawekjaranowski @bmarwell am fine, I really just wanted to have ITs run here as well.
But we started a discussion on ML to do this for all reposes (or shared? am not into GAs too much)... that would be great to implement....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants