Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MENFORCER-411] DependencyConvergence takes include/exclude parameters to filter errors #136

Merged

Conversation

fdfea
Copy link
Contributor

@fdfea fdfea commented Jan 11, 2022

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MENFORCER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MENFORCER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@fdfea fdfea force-pushed the MENFORCER-411_dependency_convergence branch 4 times, most recently from c49d941 to cf23701 Compare January 12, 2022 16:28
@fdfea fdfea force-pushed the MENFORCER-411_dependency_convergence branch from cf23701 to 1f7340f Compare January 12, 2022 17:08
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fdfea Thanks for your PR

  • simple comments to code
  • I will happy to see options with only excludes without declaring empty includes
  • please rebase code with the latest master

Please select one of checkbox about licence to acknowledge your contribution under AFS licence

@chicobento
Copy link

Hi, I see that this hasnt been changed in a long time. Are there any plans on having this brought up again and possibly merged ? Im specially looking into ways of excudling tests deps from the dep convergence analysis and I hope that this change would be of great help.

@fdfea fdfea force-pushed the MENFORCER-411_dependency_convergence branch from 72c4c22 to 6b38a24 Compare November 3, 2022 02:32
@fdfea fdfea force-pushed the MENFORCER-411_dependency_convergence branch 2 times, most recently from e322900 to 872d648 Compare November 3, 2022 03:36
@fdfea fdfea force-pushed the MENFORCER-411_dependency_convergence branch from 872d648 to d1ff1d7 Compare November 3, 2022 03:41
@fdfea
Copy link
Contributor Author

fdfea commented Nov 3, 2022

Hi @slawekjaranowski , I forgot about this PR. Thanks for taking a look at it. I've addressed your comments and rebased with master. Please take another look when you get a chance.

Do I need to sign a contributor agreement for this or will checking the "I hereby declare..." checkbox suffice?

@slawekjaranowski
Copy link
Member

Hi @fdfea please rebase and resolve conflicts.

@fdfea
Copy link
Contributor Author

fdfea commented Dec 2, 2022

@slawekjaranowski Updated

@slawekjaranowski slawekjaranowski merged commit 34b923f into apache:master Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants