Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MCOMPILER-485] Fixes internal string format in generated package-info.class #95

Merged
merged 3 commits into from Feb 22, 2022
Merged

[MCOMPILER-485] Fixes internal string format in generated package-info.class #95

merged 3 commits into from Feb 22, 2022

Commits on Feb 15, 2022

  1. [MCOMPILER-485] Add failing integration test for class file contents 

    The internal package string in the class file should contain a forward
slash
    @dbwiddis
    dbwiddis committed Feb 15, 2022
    Copy the full SHA
    8cbfb2e View commit details
    Browse the repository at this point in the history

  2. [MCOMPILER-485] Always use forward slash for internal package name 

    Per JLS 4.2.1 if the file separator character is not a forward slash,
replace it
    @dbwiddis
    dbwiddis committed Feb 15, 2022
    Copy the full SHA
    7c9f69f View commit details
    Browse the repository at this point in the history

  3. [MCOMPILER-485] Call ClassWriter#visit before ClassWriter#visitSource 

    Javadocs for org.objectweb.asm.ClassVisitor specify "The methods of this
class must be called in the following order: visit [ visitSource ] ..."
    @dbwiddis
    dbwiddis committed Feb 15, 2022
    Copy the full SHA
    d6106cb View commit details
    Browse the repository at this point in the history