[MCOMPILER-582] Automatic detection of release option for JDK < 9 #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwin
requested changes
Mar 13, 2024
There was a problem hiding this comment.
From the commit message/JIRA title it is not really clear what is changed. Maybe we can rename to Disregard release option for JDK < 9 so that this appears prominently in the release notes.
The commit message should focus on adding the IT and changing the documentation.
|
What do you think about commit subject and jira title - like: of course commit message will contain description what is added. My purpose of this change is to show new feature in release notes. |
kwin
reviewed
Mar 13, 2024
kwin
reviewed
Mar 13, 2024
kwin
reviewed
Mar 13, 2024
kwin
reviewed
Mar 13, 2024
slawekjaranowski
force-pushed
the
MCOMPILER-582
branch
from
bd6518f
to
fb261c8
Compare
- add ITs for confirm feature - extends documentation Co-authored-by: Konrad Windszus <kwin@apache.org>
slawekjaranowski
force-pushed
the
MCOMPILER-582
branch
from
fb261c8
to
e26e483
Compare
slawekjaranowski
changed the title
|
@kwin - ok, I prepare a final commit - please look if was squashed ok |
kwin
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MCOMPILER-582