Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MASSEMBLY-955] Add invoker test. #48

Closed
wants to merge 1 commit into from
Closed

Conversation

wilx
Copy link
Contributor

@wilx wilx commented Nov 16, 2021

The test fails right now due to filtering issues described in MASSEMBLY-955.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MASSEMBLY-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MASSEMBLY-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@wilx
Copy link
Contributor Author

wilx commented Nov 16, 2021

@wilx
Copy link
Contributor Author

wilx commented Jan 4, 2022

@michael-o Ping.

@cstamas
Copy link
Member

cstamas commented Jun 7, 2022

Test reused in UT here apache/maven-common-artifact-filters#25
This does not mean that this IT is to be dropped, but just FYI

@cstamas
Copy link
Member

cstamas commented Jun 8, 2022

Locally verified: the new IT fails as is (as CI proves as well), but passes ok with apache/maven-common-artifact-filters#26

[INFO] Building: projects/dependency-sets/massembly-955/pom.xml
[INFO] run post-build script verify.bsh
[INFO]           projects/dependency-sets/massembly-955/pom.xml ... SUCCESS (4.0 s)

@cstamas
Copy link
Member

cstamas commented Jun 11, 2022

Reusing this IT in another PR that opens soon

@cstamas cstamas closed this Jun 11, 2022
@cstamas
Copy link
Member

cstamas commented Jun 11, 2022

Superseded by #68

@wilx wilx deleted the MASSEMBLY-955 branch June 11, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants