[ARCHETYPE-562] Collections.sort for ordering assumes transitivity between just ordered items: #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 24, 2019 14:09
- Dependency properties evaluated using Regexp - Evaluates ordering until both lists are equal - Two properties are not ordered alphabetically - Test cases
- New ordering algorithm - Cycled paramater tests
- Prevent cycles in transitive dependencies - Improved ordering algorithm - Tests
elharo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/ARCHETYPE-562
Collections.sort for ordering assumes transitivity between just ordered items:
A < B && B < C => A < C
That's not exactly true for properties that depends on multiple previous ones.
Ordering algorithm has been reimplented taking into consideration just that one properrty may depend from one or more previous properties including GAV properties.
Property transitive values are evaluated only using the exact name reference. Using regexp we provide a way to create transitive dependencies from derived transformations of a property (toLower, toUpper, etc).