Improve instructions for building log4cxx #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rm5248
reviewed
Apr 7, 2024
src/site/markdown/4-build.md
Outdated
| As of version 0.11.0, the only supported build system for Log4cxx is CMake. | ||
| Have a look at the [build with CMake](build-cmake.html) page for more | ||
| information. If you have trouble building, either create an issue in | ||
| [Jira](https://issues.apache.org/jira/projects/LOGCXX/issues) or send a |
There was a problem hiding this comment.
Adding Github in addition to Jira here may make more sense, since we have effectively migrated to Github at this point.
There was a problem hiding this comment.
OK. I think 2 options, Github or mailing list, is sufficient.
| $ apt-get install build-essential libapr1-dev libaprutil1-dev gzip zip | ||
| $ cd apache-Log4cxx-x.x.x | ||
| $ apt-get install libapr1-dev libaprutil1-dev | ||
| $ wget https://dlcdn.apache.org/logging/log4cxx/1.3.0/apache-log4cxx-1.3.0.tar.gz |
There was a problem hiding this comment.
Do we do a CMake replacement here to always point at the latest version?
There was a problem hiding this comment.
Do we do a CMake replacement here to always point at the latest version?
Not necessary I think so I prefer to not make it even more complicated. CMakeList.txt says cmake_minimum_required(VERSION 3.13). Even Ubuntu 20.04 distro includes CMake 3.16.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides an answer to issue #362 in the documentation.