Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KARAF-7367] add Reproducible Builds support #1492

Merged
merged 1 commit into from Apr 8, 2022

Conversation

hboutemy
Copy link
Member

@skitt
Copy link
Member

skitt commented Feb 21, 2022

Rat is complaining.

@hboutemy
Copy link
Member Author

given no file was added in this commit, I don't see what it can change at Rat level
and the output of the failing build is not really helping

@jbonofre jbonofre self-requested a review February 27, 2022 11:38
@jbonofre
Copy link
Member

I suspect it's the test using MavenArchiver that doesn't output in the right target directory. I gonna take a look.

@jbonofre
Copy link
Member

This change causes the following error:

[ERROR] Failed to execute goal org.apache.karaf.tooling:karaf-maven-plugin:4.4.0-SNAPSHOT:kar (package) on project framework: Execution package of goal org.apache.karaf.tooling:karaf-maven-plugin:4.4.0-SNAPSHOT:kar failed: An API incompatibility was encountered while executing org.apache.karaf.tooling:karaf-maven-plugin:4.4.0-SNAPSHOT:kar: java.lang.NoSuchMethodError: org.codehaus.plexus.util.DirectoryScanner.setFilenameComparator(Ljava/util/Comparator;)V

I think the problem is related to maven/plexus dep update. I will take a look.

@hboutemy
Copy link
Member Author

oh, you need to update plexus-utils to a recent release: resolution seems to prefer an older version than required by maven-archiver

@hboutemy
Copy link
Member Author

strangely, I tested ITs, so I don't get how you got such result while everything runs fine for me...

@hboutemy
Copy link
Member Author

hboutemy commented Mar 18, 2022

you'll need to update plexus-utils.version property to 3.3.0 minimum (currently 3.2.1) to benefit from codehaus-plexus/plexus-utils#70
it's in root pom.xml: I suppose I forgot to commit it...

@jbonofre jbonofre merged commit dbebfcd into apache:main Apr 8, 2022
@hboutemy hboutemy deleted the KARAF-7367 branch April 9, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants