Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-8786: Deprecated Gradle features making it incompatible with Gradle 6.0 #7190

Closed
wants to merge 1 commit into from

Conversation

aljoshare
Copy link
Contributor

The lines 549-552 of the build.gradle makes it incompatible with Gradle 6.0. It was fixed by changing

additionalSourceDirs = files(javaProjects.sourceSets.main.allSource.srcDirs)
sourceDirectories = files(javaProjects.sourceSets.main.allSource.srcDirs)
classDirectories = files(javaProjects.sourceSets.main.output)
executionData = files(javaProjects.jacocoTestReport.executionData)

to

additionalSourceDirs.from = javaProjects.sourceSets.main.allSource.srcDirs
sourceDirectories.from = javaProjects.sourceSets.main.allSource.srcDirs
classDirectories.from = javaProjects.sourceSets.main.output
executionData.from = javaProjects.jacocoTestReport.executionData

No expected changes to unit or integration tests.

@aljoshare aljoshare changed the title KAFKA-8786 KAFKA-8786: Deprecated Gradle features making it incompatible with Gradle 6.0. Aug 10, 2019
@aljoshare aljoshare changed the title KAFKA-8786: Deprecated Gradle features making it incompatible with Gradle 6.0. KAFKA-8786: Deprecated Gradle features making it incompatible with Gradle 6.0 Aug 10, 2019
@stanislavkozlovski
Copy link
Contributor

Is there an expected date for Gradle 6.0? I couldn't find it in https://gradle.org/releases/

@aljoshare
Copy link
Contributor Author

There is no specific date but the period between the major releases is about a year which implies that version 6.0 will probably be released in the fourth quarter of 2019

@stanislavkozlovski
Copy link
Contributor

Right, does this compile with the current gradle version?

retest this please

@ijuma
Copy link
Contributor

ijuma commented Sep 28, 2019

Gradle 6.0 is the next release and it's required for Java 13 support (unfortunately).

@ijuma
Copy link
Contributor

ijuma commented Sep 28, 2019

retest this please

@ijuma
Copy link
Contributor

ijuma commented Sep 28, 2019

Thanks for the PR. We need to update the readme to specify the minimum version of gradle required after these changes.

@ijuma
Copy link
Contributor

ijuma commented Nov 11, 2019

This will be done as part of #7909. I'll credit @AljoschaP as the co-author of the change.

@ijuma ijuma closed this Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants