Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Remove usage of Stream API in CoordinatorRecordHelpers #15969

Merged
merged 1 commit into from
May 16, 2024

Conversation

dajac
Copy link
Contributor

@dajac dajac commented May 15, 2024

This patch removes the usage of the Stream API in CoordinatorRecordHelpers. I saw it in a couple of profiles so it is better to remove it.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@dajac dajac added the KIP-848 label May 15, 2024
@dajac dajac requested a review from chia7712 May 15, 2024 16:29
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

so sad that java stream is not welcome in the profiler :(

@jolshan
Copy link
Contributor

jolshan commented May 16, 2024

Thread leak strikes again...I restarted the build.

@dajac dajac merged commit ffb31e1 into apache:trunk May 16, 2024
1 check failed
@dajac dajac deleted the minor-remove-stream-api-in-record-helpers branch May 16, 2024 06:13
rreddy-22 pushed a commit to rreddy-22/kafka-rreddy that referenced this pull request May 24, 2024
…#15969)

This patch removes the usage of the Stream API in CoordinatorRecordHelpers. I saw it in a couple of profiles so it is better to remove it.

Reviewers: Justine Olshan <jolshan@confluent.io>, Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants