Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-7342: Migrate tests in remaining packages in o.a.k.streams #15963

Merged
merged 1 commit into from
May 15, 2024

Conversation

cadonna
Copy link
Contributor

@cadonna cadonna commented May 15, 2024

Migrates tests in the following packages (excluding subpackages) to JUnit 5:

  • org.apache.kafka.streams.internals
  • org.apache.kafka.streams.kstream
  • org.apache.kafka.streams.processor
  • org.apache.kafka.streams.query
  • org.apache.kafka.streams.state
  • org.apache.kafka.streams.tests
  • org.apache.kafka.streams.utils

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Migrates tests in the following packages (excluding subpackages)
to JUnit 5:
- org.apache.kafka.streams.internals
- org.apache.kafka.streams.kstream
- org.apache.kafka.streams.processor
- org.apache.kafka.streams.query
- org.apache.kafka.streams.state
- org.apache.kafka.streams.tests
- org.apache.kafka.streams.utils
@cadonna cadonna requested a review from clolov May 15, 2024 12:42
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I guess you don't want to create a huge PR to migrate all tests of streams at once?

@cadonna
Copy link
Contributor Author

cadonna commented May 15, 2024

LGTM

I guess you don't want to create a huge PR to migrate all tests of streams at once?

Yeah, that is the idea.

@cadonna cadonna merged commit ba19eed into apache:trunk May 15, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants