KAFKA-16513: Add test for WriteTxnMarkers with AlterCluster permission #15952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikramakrishnan
force-pushed
the
kip1037-addTest
branch
from
11910ec
to
fa3747f
Compare
clolov
approved these changes
May 21, 2024
rreddy-22
pushed a commit
to rreddy-22/kafka-rreddy
that referenced
this pull request
May 24, 2024
In apache#15837, we introduced the change to allow calling the WriteTxnMarkers API with AlterCluster permissions. This PR proposes 2 enhancements: - When a WriteTxnMarkers request is received, it is first authorized against the alter cluster permission. If the user does not have this permission, a 'deny' will be logged. However, if the user does have the cluster action permission, the request will be successfully authorized. Don't log the first deny to avoid confusion. - Add a `WriteTxnMarkersRequest` to be called from the test `testAuthorizationWithTopicExisting`, so that the request can be exercised and verified with both possible permissions. Author: Nikhil Ramakrishnan <nikrmk@amazon.com> Reviewers: Christo Lolov <lolovc@amazon.com> Closes apache#15952 from nikramakrishnan/kip1037-addTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #15837, we introduced the change to allow calling the WriteTxnMarkers API with AlterCluster permissions. This PR proposes 2 enhancements:
WriteTxnMarkersRequestto be called from the testtestAuthorizationWithTopicExisting, so that the request can be exercised and verified with both possible permissions.Committer Checklist (excluded from commit message)