-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: revisit LogValidatorTest#checkRecompression #15948
Conversation
ping @junrao @vincent81jiang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chia7712 : Thanks for the PR. Just a couple of minor comments.
@junrao thanks for all your reviews :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chia7712 : Thanks for the updated PR. LGTM.
The test failures seem unrelated, but it would be useful to file jiras for the untracked ones.
from #15904 (comment)
Committer Checklist (excluded from commit message)