Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: revisit LogValidatorTest#checkRecompression #15948

Merged
merged 3 commits into from
May 15, 2024

Conversation

chia7712
Copy link
Contributor

from #15904 (comment)

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@chia7712
Copy link
Contributor Author

ping @junrao @vincent81jiang

Copy link
Contributor

@junrao junrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chia7712 : Thanks for the PR. Just a couple of minor comments.

core/src/test/scala/unit/kafka/log/LogValidatorTest.scala Outdated Show resolved Hide resolved
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala Outdated Show resolved Hide resolved
@chia7712
Copy link
Contributor Author

@junrao thanks for all your reviews :)

Copy link
Contributor

@junrao junrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chia7712 : Thanks for the updated PR. LGTM.

The test failures seem unrelated, but it would be useful to file jiras for the untracked ones.

@chia7712
Copy link
Contributor Author

test jira
testDelayedConfigurationOperations https://issues.apache.org/jira/browse/KAFKA-16773
testOffsetTranslationBehindReplicationFlow https://issues.apache.org/jira/browse/KAFKA-15197
testAlterSinkConnectorOffsets https://issues.apache.org/jira/browse/KAFKA-15892
testElectPreferredLeaders https://issues.apache.org/jira/browse/KAFKA-8458
testSeparateOffsetsTopic https://issues.apache.org/jira/browse/KAFKA-14089
testNoConsumeWithoutDescribeAclViaSubscribe https://issues.apache.org/jira/browse/KAFKA-9655
testNoConsumeWithDescribeAclViaSubscribe https://issues.apache.org/jira/browse/KAFKA-7646
testCreateUserWithDelegationToken https://issues.apache.org/jira/browse/KAFKA-16501
testDescribeTokenForOtherUserFails https://issues.apache.org/jira/browse/KAFKA-15411
testCoordinatorFailover https://issues.apache.org/jira/browse/KAFKA-16024
shouldWorkWithUncleanShutdownWipeOutStateStore https://issues.apache.org/jira/browse/KAFKA-16502
shouldCloseAllTaskProducersOnCloseIfEosEnabled https://issues.apache.org/jira/browse/KAFKA-16774
testTaskRequestWithOldStartMsGetsUpdated https://issues.apache.org/jira/browse/KAFKA-8115
testSyncTopicConfigs https://issues.apache.org/jira/browse/KAFKA-14453
testReplicateSourceDefault https://issues.apache.org/jira/browse/KAFKA-15292
testCreateTokenForOtherUserFails https://issues.apache.org/jira/browse/KAFKA-15411
testDescribeTokenForOtherUserFails https://issues.apache.org/jira/browse/KAFKA-15411
testCreateExistingTopicsThrowTopicExistsException https://issues.apache.org/jira/browse/KAFKA-16775
testLowMaxFetchSizeForRequestAndPartition https://issues.apache.org/jira/browse/KAFKA-16494
testTaskRequestWithOldStartMsGetsUpdated https://issues.apache.org/jira/browse/KAFKA-8115

@chia7712 chia7712 merged commit aca5d24 into apache:trunk May 15, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants