KAFKA-16223: Replace EasyMock/PowerMock with Mockito for KafkaConfigBackingStoreTest #15933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankYang0529
force-pushed
the
KAFKA-16223
branch
from
a01a64d
to
3fe732d
Compare
chia7712
reviewed
May 15, 2024
| @@ -960,6 +666,14 @@ private void expectConvertWriteRead(final String configKey, final Schema valueSc | |||
| }); | |||
| } | |||
|
|
|||
| private void expectConvertWriteAndRead(final String configKey, final Schema valueSchema, final byte[] serialized, | |||
There was a problem hiding this comment.
please remove this unused function
There was a problem hiding this comment.
Removed it. Thanks.
FrankYang0529
force-pushed
the
KAFKA-16223
branch
from
3fe732d
to
42c5b4f
Compare
|
@FrankYang0529 Could you please rebase code to trigger QA ? |
|
@chia7712 I triggered a rebuild. You can do it to if you login to the underlying Jenkins: https://issues.apache.org/jira/browse/INFRA-25442 |
Big thanks! |
…ackingStoreTest Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
KAFKA-16223
branch
from
42c5b4f
to
34212aa
Compare
rreddy-22
pushed a commit
to rreddy-22/kafka-rreddy
that referenced
this pull request
May 24, 2024
…ckingStoreTest (apache#15933) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)