JAMES-3891 Graceful shutdown for queue consumers [3.7.x] #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arsnael
approved these changes
Mar 14, 2023
quantranhong1999
approved these changes
Mar 14, 2023
|
I wonder about the test failures here. I did a quick test and locally all is well. So is this a matter of timing, test(suite) isolation, or an artifact of the CI build environment? |
|
Build is especially unstable lately due to recent ci update |
|
That must be it, I just ran the entire webadmin-integration-test suite and all was fine. So is this CI issue going to block the 3.7.4 release? |
|
We did some fixes on the jenkins build following the CI chaotic upgrade... I just restarted your build, let's hope it goes better this time |
vttranlina
reviewed
Mar 16, 2023
...ilets/src/main/java/org/apache/james/transport/mailets/remote/delivery/DeliveryRunnable.java
Outdated
Show resolved
Hide resolved
Graceful shutdown for scheduler is a late addition to the reactor framework, hence I propose an alternative to it.
quantranhong1999
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graceful shutdown for scheduler is a late addition to the reactor framework, hence I propose an alternative to it.
CF reactor/reactor-core#3089