Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipe: Replaced IDeviceID in pipe module #12551

Closed
wants to merge 4 commits into from
Closed

Pipe: Replaced IDeviceID in pipe module #12551

wants to merge 4 commits into from

Conversation

Caideyipi
Copy link
Contributor

Description

As the title said.

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.
Key changed/added classes (or packages if there are too many classes) in this PR

@SteveYurongSu SteveYurongSu requested review from JackieTien97 and SteveYurongSu and removed request for JackieTien97 May 20, 2024 07:01
@SteveYurongSu SteveYurongSu self-assigned this May 20, 2024
@Caideyipi Caideyipi closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveYurongSu SteveYurongSu Awaiting requested review from SteveYurongSu

@JackieTien97 JackieTien97 Awaiting requested review from JackieTien97

Assignees

@SteveYurongSu SteveYurongSu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Caideyipi @SteveYurongSu