Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect query result in GROUP BY LEVEL query with logical view #12550

Merged
merged 6 commits into from
May 29, 2024

Conversation

liuminghui233
Copy link
Member

@liuminghui233 liuminghui233 commented May 19, 2024

create view root.sg1.d3.s1 as root.sg1.d1.s1

image

Before:
image

After:
image

Copy link

codecov bot commented May 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.37%. Comparing base (3a28a2e) to head (2eb3d56).
Report is 3 commits behind head on master.

Current head 2eb3d56 differs from pull request most recent head 879459c

Please upload reports for the commit 879459c to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12550      +/-   ##
============================================
+ Coverage     42.93%   43.37%   +0.43%     
  Complexity       69       69              
============================================
  Files          3192     3166      -26     
  Lines        199056   196852    -2204     
  Branches      23721    23444     -277     
============================================
- Hits          85471    85381      -90     
+ Misses       113585   111471    -2114     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liuminghui233 liuminghui233 marked this pull request as draft May 27, 2024 08:45
@liuminghui233 liuminghui233 marked this pull request as ready for review May 27, 2024 08:51
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@JackieTien97 JackieTien97 merged commit 9a5b02a into master May 29, 2024
54 of 58 checks passed
@JackieTien97 JackieTien97 deleted the lmh/fixGroupByLevelView branch May 29, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants