-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOTDB-6325] Support RegionScan for active metadata queries [BE Part One] #12539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or DeviceRegionScan
JackieTien97
requested changes
May 19, 2024
...core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/driver/DataDriver.java
Outdated
Show resolved
Hide resolved
.../datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/fragment/QueryContext.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/ModificationUtils.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/ModificationUtils.java
Outdated
Show resolved
Hide resolved
...de/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/AbstractMemTable.java
Show resolved
Hide resolved
...ava/org/apache/iotdb/db/storageengine/dataregion/read/filescan/impl/DiskChunkHandleImpl.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/iotdb/db/storageengine/dataregion/read/filescan/impl/DiskChunkHandleImpl.java
Show resolved
Hide resolved
...ava/org/apache/iotdb/db/storageengine/dataregion/read/filescan/impl/DiskChunkHandleImpl.java
Outdated
Show resolved
Hide resolved
.../apache/iotdb/db/storageengine/dataregion/read/filescan/impl/DiskAlignedChunkHandleImpl.java
Outdated
Show resolved
Hide resolved
.../apache/iotdb/db/storageengine/dataregion/read/filescan/impl/DiskAlignedChunkHandleImpl.java
Outdated
Show resolved
Hide resolved
JackieTien97
requested changes
May 22, 2024
iotdb-core/confignode/src/test/resources/confignode1conf/iotdb-common.properties
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/ModificationUtils.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/ModificationUtils.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/iotdb/db/storageengine/dataregion/utils/SharedTimeDataBuffer.java
Outdated
Show resolved
Hide resolved
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java
Outdated
Show resolved
Hide resolved
.../apache/iotdb/db/storageengine/dataregion/read/filescan/impl/UnclosedFileScanHandleImpl.java
Outdated
Show resolved
Hide resolved
.../apache/iotdb/db/storageengine/dataregion/read/filescan/impl/UnclosedFileScanHandleImpl.java
Outdated
Show resolved
Hide resolved
...rg/apache/iotdb/db/storageengine/dataregion/read/filescan/impl/ClosedFileScanHandleImpl.java
Outdated
Show resolved
Hide resolved
JackieTien97
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to find the metaData which is activate during a period of time, we need to scan the raw data.
Current implementation of seriesScan may cause random access due to the access to one TSFile repeatedly. We could use file scan to eliminate this.
Region scan is the feature in IoTDB to support fileScan, this PR would support basic FileHandle for TsFile which support file-based scanning.
FileScanHandle corresponds to a TsFile and is used for related metadata operations and data scanning on the TsFile; ChunkHandle corresponds to specific chunk data, and we can obtain a batch of ChunkHandle for sequential scanning through the interface of FileScanHandle.
The relationship between the related classes is shown in the following diagram.TsFileResource is original implementation. Among red ones, DiskChunkHandle is used to access chunks on the disk, while MemChunkHandle is used to access data in the MemTable. Due to the possibility of partially flushed MemTables, UnclosedFileScanHandle will include both of these scenarios.