NO-ISSUE: Add range and enum DMN Runner validation for the time, date, date-time and duration types of the new Type Constraint property #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagobento
approved these changes
May 17, 2024
|
Looking |
jomarko
reviewed
May 20, 2024
There was a problem hiding this comment.
Thank you for this PR. For me it seems working for most of the data types. However I see some issue for date and time
This attached model is simple id function, it takes the input (date and time) and return the same value.
If the dmn built in date and time is used, it works well, see:
However if the input data node data type is changed to tDateAndTime, it crashes.
Please notice the extended servies needs to be running.
|
Apparently, the string is converted to a Date class after a new edit, and I'm not sure why. I've added a new line to handle this case. @jomarko Thanks for spotting this one. |
jomarko
approved these changes
May 21, 2024
tiagobento
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new DMN editor uses the new
type constraintsproperty to set the Item Definition/Item Components constraint. This new property is mapped to the JSON Schemax-dmn-type-constraintskeyword. This PR adds the property to the AJV validator. This PR also break the fileconstantsinto multiple specific ones.Before:
After:
