New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KOGITO-8351] - Introduce Camel Add-On for Serverless Workflow #2689
Conversation
simple: '{ "id": "${header.WorkflowID}", "arg1": { "arg2": "value1" } }' | ||
- unmarshal: | ||
json: | ||
library: Jackson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...ent/src/main/java/org/kie/kogito/addons/quarkus/camel/deployment/CamelFunctionNamespace.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/kie/kogito/addons/quarkus/camel/deployment/CamelFunctionStaticValidator.java
Show resolved
Hide resolved
...c/main/java/org/kie/kogito/addons/quarkus/camel/deployment/CamelFunctionStaticValidator.java
Outdated
Show resolved
Hide resolved
...mel/runtime/src/main/java/org/kie/kogito/addons/quarkus/camel/runtime/CamelConfigSource.java
Show resolved
Hide resolved
...mel/runtime/src/main/java/org/kie/kogito/addons/quarkus/camel/runtime/CamelFunctionArgs.java
Outdated
Show resolved
Hide resolved
...time/src/main/java/org/kie/kogito/addons/quarkus/camel/runtime/CamelConfigSourceFactory.java
Show resolved
Hide resolved
...me/src/main/java/org/kie/kogito/addons/quarkus/camel/runtime/CamelCustomWorkItemHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but we can save some code
...me/src/main/java/org/kie/kogito/addons/quarkus/camel/runtime/CamelCustomWorkItemHandler.java
Show resolved
Hide resolved
...c/main/java/org/kie/kogito/addons/quarkus/camel/deployment/CamelFunctionStaticValidator.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/kie/kogito/addons/quarkus/camel/deployment/CamelFunctionStaticValidator.java
Outdated
Show resolved
Hide resolved
b7a5e92
to
78fa07e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ricardozanini nice work!
Im just thinking about the version alignment. DO we know if our Quarkus upgrade script will pick the upgrade or is it something we will need to do manually? @radtriste FYI
...c/main/java/org/kie/kogito/addons/quarkus/camel/deployment/CamelFunctionStaticValidator.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/kie/kogito/addons/quarkus/camel/deployment/CamelFunctionStaticValidator.java
Outdated
Show resolved
Hide resolved
...main/java/org/kie/kogito/addons/quarkus/camel/deployment/CamelWorkItemFunctionNamespace.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/org/kie/kogito/addons/quarkus/camel/deployment/CamelWorkItemTypeHandler.java
Outdated
Show resolved
Hide resolved
quarkus/addons/camel/deployment/src/test/resources/camel-soap-expression-args.sw.json
Outdated
Show resolved
Hide resolved
quarkus/addons/camel/integration-tests/src/main/resources/routes/log-route-replace-header.yaml
Show resolved
Hide resolved
Our scripts will not if the version is not in the io.quarkus:quarkus-bom |
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
It's not there. So we will have to fetch from their platform? Honestly, I can remove this version since we only needed it because of the Camel DSL XSD. |
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
dd3919e
to
931ab20
Compare
@radtriste I've removed the Camel version. Now we can rely only on Camel Quarkus. I'll fix the example as well. |
jenkins rerun kogito-runtimes tests |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Ricardo Zanini zanini@redhat.com
See: https://issues.redhat.com/browse/KOGITO-8351
In this PR, we introduce a new feature capable of adding Camel routes in Serverless Workflow projects and call them using the workflow DSL.
Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
KOGITO-XYZ Subject
[0.9.x] KOGITO-XYZ Subject
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request checks
Please add comment: Jenkins retest this
for a specific pull request check
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] tests
for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch
for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch
for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main
for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-main
for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts
for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts
for native checks
Run native checks
Please add comment: Jenkins run native
for a specific native check
Run native checks
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] native
for mandrel checks
Run native checks against Mandrel image
Please add comment: Jenkins run mandrel
for a specific mandrel check
Run native checks against Mandrel image
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] mandrel
for mandrel lts checks
Run native checks against Mandrel image and quarkus lts branch
Please add comment: Jenkins run mandrel-lts
for a specific mandrel lts check
Run native checks against Mandrel image and quarkus lts branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] mandrel-lts
Full Kogito testing (with cloud images and operator BDD testing)
Please add comment: Jenkins run BDD
This check should be used only if a big change is done as it takes time to run, need resources and one full BDD tests check can be done at a time ...