-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-19173. Upgrade org.apache.derby:derby to 10.17.1.0. #6836
Conversation
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@slfan1989 derby 10.17.1.0 isn't compatible with Java 8. There are two RBF test that are failing. I've added details in https://issues.apache.org/jira/browse/HDFS-17533 |
@simbadzina I have rolled back #6816. Sorry for the inconvenience caused. In the future, when upgrading jar versions, I will pay attention to the compatibility of the jar packages with Jdk. cc: @steveloughran |
I will close this pr, and then continue to follow up on the derby version upgrade. |
No problem. Thanks for the quick revert @slfan1989. derby still needs to be added to the LICENCE-binary file like you were doing in this PR. Can you do that for |
Thanks for your reminder! I will submit a pr to fix this issue. |
Description of PR
JIRA: HADOOP-19173. Upgrade org.apache.derby:derby to 10.17.1.0.
In #6816, we upgraded the version of Derby but forgot to update the LICENSE-binary file. This PR will address the update for the LICENSE-binary file.
How was this patch tested?
no-test.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?