Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-19173. Upgrade org.apache.derby:derby to 10.17.1.0. #6836

Closed
wants to merge 1 commit into from

Conversation

slfan1989
Copy link
Contributor

@slfan1989 slfan1989 commented May 18, 2024

Description of PR

JIRA: HADOOP-19173. Upgrade org.apache.derby:derby to 10.17.1.0.

In #6816, we upgraded the version of Derby but forgot to update the LICENSE-binary file. This PR will address the update for the LICENSE-binary file.

How was this patch tested?

no-test.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@github-actions github-actions bot added the trunk label May 18, 2024
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 21m 9s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 shadedclient 41m 10s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 shadedclient 32m 12s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 38s The patch does not generate ASF License warnings.
100m 31s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6836/1/artifact/out/Dockerfile
GITHUB PR #6836
Optional Tests dupname asflicense codespell detsecrets shellcheck shelldocs
uname Linux 1650b32fcbf9 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 9eadc97
Max. process+thread count 553 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6836/1/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@simbadzina
Copy link
Member

simbadzina commented May 20, 2024

@slfan1989 derby 10.17.1.0 isn't compatible with Java 8. There are two RBF test that are failing. I've added details in https://issues.apache.org/jira/browse/HDFS-17533

@slfan1989
Copy link
Contributor Author

@simbadzina I have rolled back #6816. Sorry for the inconvenience caused. In the future, when upgrading jar versions, I will pay attention to the compatibility of the jar packages with Jdk.

cc: @steveloughran

@slfan1989
Copy link
Contributor Author

I will close this pr, and then continue to follow up on the derby version upgrade.

@slfan1989 slfan1989 closed this May 21, 2024
@simbadzina
Copy link
Member

@simbadzina I have rolled back #6816. Sorry for the inconvenience caused. In the future, when upgrading jar versions, I will pay attention to the compatibility of the jar packages with Jdk.

cc: @steveloughran

No problem. Thanks for the quick revert @slfan1989. derby still needs to be added to the LICENCE-binary file like you were doing in this PR. Can you do that for 10.14.2.0?

@slfan1989
Copy link
Contributor Author

No problem. Thanks for the quick revert @slfan1989. derby still needs to be added to the LICENCE-binary file like you were doing in this PR. Can you do that for 10.14.2.0?

Thanks for your reminder! I will submit a pr to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants