-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YARN-11687. CGroupV2 resource calculator #6835
Conversation
Change-Id: I256aead1719f1d112e84a1b2c3e77b08b1bf8cce
💔 -1 overall
This message was automatically generated. |
…roupv2 - fix style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @K0K0V0K! I had some minor comments on wording.
...doop/yarn/server/nodemanager/containermanager/linux/resources/CGroupsResourceCalculator.java
Outdated
Show resolved
Hide resolved
...op/yarn/server/nodemanager/containermanager/linux/resources/CGroupsV2ResourceCalculator.java
Outdated
Show resolved
Hide resolved
...op/yarn/server/nodemanager/containermanager/linux/resources/CGroupsV2ResourceCalculator.java
Outdated
Show resolved
Hide resolved
...op/yarn/server/nodemanager/containermanager/linux/resources/CGroupsV2ResourceCalculator.java
Outdated
Show resolved
Hide resolved
...op/yarn/server/nodemanager/containermanager/linux/resources/CGroupsV2ResourceCalculator.java
Outdated
Show resolved
Hide resolved
...doop/yarn/server/nodemanager/containermanager/linux/resources/CGroupsResourceCalculator.java
Outdated
Show resolved
Hide resolved
...doop/yarn/server/nodemanager/containermanager/linux/resources/CGroupsResourceCalculator.java
Outdated
Show resolved
Hide resolved
...doop/yarn/server/nodemanager/containermanager/linux/resources/CGroupsResourceCalculator.java
Outdated
Show resolved
Hide resolved
...op/yarn/server/nodemanager/containermanager/linux/resources/CGroupsV2ResourceCalculator.java
Outdated
Show resolved
Hide resolved
…-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/CGroupsV2ResourceCalculator.java Co-authored-by: Benjamin Teke <brumi1024@users.noreply.github.com>
…-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/CGroupsV2ResourceCalculator.java Co-authored-by: Benjamin Teke <brumi1024@users.noreply.github.com>
…-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/CGroupsV2ResourceCalculator.java Co-authored-by: Benjamin Teke <brumi1024@users.noreply.github.com>
…-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/CGroupsResourceCalculator.java Co-authored-by: Benjamin Teke <brumi1024@users.noreply.github.com>
…-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/CGroupsResourceCalculator.java Co-authored-by: Benjamin Teke <brumi1024@users.noreply.github.com>
…-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/CGroupsResourceCalculator.java Co-authored-by: Benjamin Teke <brumi1024@users.noreply.github.com>
…-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/CGroupsV2ResourceCalculator.java Co-authored-by: Benjamin Teke <brumi1024@users.noreply.github.com>
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
…roupv2 - fix by review
💔 -1 overall
This message was automatically generated. |
…roupv2 - fix style
💔 -1 overall
This message was automatically generated. |
…roupv2 - fix possible NPE
💔 -1 overall
This message was automatically generated. |
...doop/yarn/server/nodemanager/containermanager/linux/resources/CGroupsResourceCalculator.java
Outdated
Show resolved
Hide resolved
...op/yarn/server/nodemanager/containermanager/linux/resources/CGroupsV2ResourceCalculator.java
Outdated
Show resolved
Hide resolved
…-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/CGroupsResourceCalculator.java Co-authored-by: Benjamin Teke <brumi1024@users.noreply.github.com>
…-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/CGroupsV2ResourceCalculator.java Co-authored-by: Benjamin Teke <brumi1024@users.noreply.github.com>
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
…roupv2 - fix style
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @K0K0V0K for the patch, the latest state LGTM. The javadoc issue seems unrelated, merging to trunk.
Description of PR
How was this patch tested?