-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. #6795
Conversation
...on/src/main/java/org/apache/hadoop/yarn/server/federation/cache/FederationCaffeineCache.java
Show resolved
Hide resolved
...on/src/main/java/org/apache/hadoop/yarn/server/federation/cache/FederationCaffeineCache.java
Show resolved
Hide resolved
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@@ -536,7 +536,7 @@ To enable cross-origin support (CORS) for the Yarn Router, please set the follow | |||
#### How to configure Router Cache | |||
|
|||
Cache is enabled by default. When we set the `yarn.federation.cache-ttl.secs` parameter and its value is greater than 0, Cache will be enabled. | |||
We currently provide two Cache implementations: `JCache` and `GuavaCache`. | |||
We currently provide Three Cache implementations: `JCache` , `GuavaCache`, `CaffeineCache` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
three
with lower case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestions! I will improve the documentation.
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@goiri Can you help review this pr again? Thank you very much! The error reported by mvn compilation is not caused by our changes. |
💔 -1 overall
This message was automatically generated. |
@goiri Thank you very much for reviewing the code! I merged this pr into the trunk branch. The related compilation error has nothing to do with our code. |
Description of PR
JIRA: YARN-11471. FederationStateStoreFacade Cache Support Caffeine.
In YARN Federation, we already support two types of cache:
Currently, another popular Java cache is CaffeineCache, which has better execution performance and is more actively updated. It is a cache supported by the Apache license.
Project homepage:
https://github.com/ben-manes/caffeine
We can learn about the performance of this cache from the following documentation:
How was this patch tested?
Using historical frameworks for unit testing.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?