Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HADOOP-18300. Upgrade Gson dependency to version 2.9.0 #4454

Merged
merged 2 commits into from Jun 22, 2022
Merged

HADOOP-18300. Upgrade Gson dependency to version 2.9.0 #4454

merged 2 commits into from Jun 22, 2022

Conversation

medb
Copy link
Contributor

@medb medb commented Jun 17, 2022

Description of PR

Upgrade Gson dependency to version 2.9.0

How was this patch tested?

Presubmit/CI

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 40s Maven dependency ordering for branch
+1 💚 mvninstall 27m 49s trunk passed
+1 💚 compile 25m 2s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 compile 21m 37s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 mvnsite 2m 41s trunk passed
+1 💚 javadoc 2m 38s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javadoc 2m 33s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 shadedclient 120m 15s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 29s Maven dependency ordering for patch
+1 💚 mvninstall 9m 10s the patch passed
+1 💚 compile 24m 11s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javac 24m 11s the patch passed
+1 💚 compile 21m 40s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javac 21m 40s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 2m 37s the patch passed
+1 💚 javadoc 2m 32s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javadoc 2m 32s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 shadedclient 34m 10s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 50s hadoop-project in the patch passed.
+1 💚 unit 0m 50s hadoop-client-runtime in the patch passed.
+1 💚 unit 0m 51s hadoop-client-minicluster in the patch passed.
+1 💚 asflicense 1m 16s The patch does not generate ASF License warnings.
216m 41s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4454/2/artifact/out/Dockerfile
GITHUB PR #4454
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname Linux 2f6eaa030b7d 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 9d857e0
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4454/2/testReport/
Max. process+thread count 536 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4454/2/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ayushtkn
ayushtkn reviewed Jun 20, 2022
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update here as well
https://github.com/apache/hadoop/blob/trunk/LICENSE-binary#L234

hadoop-client-modules/hadoop-client-runtime/pom.xml Show resolved Hide resolved
@medb medb requested a review from ayushtkn June 20, 2022 16:12
@medb
Copy link
Contributor Author

medb commented Jun 20, 2022

You need to update here as well https://github.com/apache/hadoop/blob/trunk/LICENSE-binary#L234

Thanks for pointer, updated.

ayushtkn
ayushtkn approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, If the Jenkins doesn't report any failures.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 4s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 28s Maven dependency ordering for branch
+1 💚 mvninstall 29m 19s trunk passed
+1 💚 compile 27m 23s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 compile 22m 39s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 mvnsite 20m 36s trunk passed
+1 💚 javadoc 8m 52s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javadoc 7m 51s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 shadedclient 39m 45s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for patch
+1 💚 mvninstall 35m 2s the patch passed
+1 💚 compile 24m 24s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javac 24m 24s the patch passed
+1 💚 compile 21m 47s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javac 21m 47s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 19m 19s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 8m 22s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javadoc 7m 31s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 shadedclient 40m 8s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 1090m 21s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 2m 25s The patch does not generate ASF License warnings.
1392m 3s
Reason Tests
Failed junit tests hadoop.mapred.TestLocalDistributedCacheManager
hadoop.yarn.server.router.webapp.TestRouterWebServicesREST
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4454/3/artifact/out/Dockerfile
GITHUB PR #4454
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname Linux e4643aa56a86 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 9b556d4
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4454/3/testReport/
Max. process+thread count 2638 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4454/3/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@cnauroth cnauroth self-requested a review June 21, 2022 18:04
@cnauroth
Copy link
Contributor

+1

trunk, branch-3.3 and branch-3.2 are all currently on GSON 2.8.9 and can take a backward-compatible upgrade to 2.9.0. I'll plan on committing to those 3 branches.

@ayushtkn
Copy link
Member

Thanx @cnauroth for giving a check, just give a check to the Yarn test failure before merging, the other one I know isn't related.

In case interested Hive too uses Gson and if you folks are interested we can keep the version in sync there as well:
https://github.com/apache/hive/blob/master/pom.xml#L207

Hive is moving to hadoop 3.1.x line to 3.3.x line. :-)

@cnauroth
Copy link
Contributor

@ayushtkn , I forgot to mention that test failures look unrelated to me, but I'll be clarifying with an independent test run before I commit.

Thanks for the tip on Hive. I'll check it out.

@cnauroth
Copy link
Contributor

I've confirmed that the failure in TestRouterWebServicesREST is unrelated. (See YARN-11192.) I'll begin committing this shortly.

@cnauroth cnauroth merged commit 77d1b19 into apache:trunk Jun 22, 2022
asfgit pushed a commit that referenced this pull request Jun 23, 2022
@medb @cnauroth
HADOOP-18300. Upgrade Gson dependency to version 2.9.0 (#4454)
d41e0a9 
Reviewed-by: Ayush Saxena <ayushsaxena@apache.org>
Signed-off-by: Chris Nauroth <cnauroth@apache.org>
(cherry picked from commit 77d1b19)
asfgit pushed a commit that referenced this pull request Jun 23, 2022
@medb @cnauroth
HADOOP-18300. Upgrade Gson dependency to version 2.9.0 (#4454)
399580d 
Reviewed-by: Ayush Saxena <ayushsaxena@apache.org>
Signed-off-by: Chris Nauroth <cnauroth@apache.org>
(cherry picked from commit 77d1b19)
(cherry picked from commit d41e0a9)
@medb medb deleted the patch-1 branch June 23, 2022 00:45
@medb
Copy link
Contributor Author

medb commented Jun 23, 2022

Thank you for the reviews and merging PR!

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
@medb
HADOOP-18300. Upgrade Gson dependency to version 2.9.0 (apache#4454)
cf52ca8 
Reviewed-by: Ayush Saxena <ayushsaxena@apache.org>
Signed-off-by: Chris Nauroth <cnauroth@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnauroth cnauroth cnauroth approved these changes

@ayushtkn ayushtkn ayushtkn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@medb @hadoop-yetus @cnauroth @ayushtkn