Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue#9953 #9978

Merged
merged 3 commits into from May 7, 2022
Merged

Fix issue#9953 #9978

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b31eafc
Fix The first element of the queue cannot be deleted when an exceptio…
106umao Apr 28, 2022
ca800bf
Fix Modify the log queue traversal method (#9953)
106umao Apr 29, 2022
b88d43a
Fix Modify the log queue traversal method (#9953)
106umao Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/AccessLogFilter.java
View file
Open in desktop
Expand Up @@ -141,6 +141,7 @@ private void writeLogQueueToFile(String accessLog, Queue<AccessLogData> logQueue
processWithAccessKeyLogger(logQueue, file);
}
} catch (Exception e) {
logQueue.poll();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be better to modify the traversal method of the queue.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be better to modify the traversal method of the queue.

Yes, I think so too, but I'm afraid that changing too much code might not be acceptable

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be better to modify the traversal method of the queue.

And if you modify the queue traversal methods so processWithAccessKeyLogger two overloaded methods need to be modified

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, maybe I didn't express it clearly, you should handle exceptions in processWithAccessKeyLogger, and you also need to dequeue operations. If the queue is not empty, the while operation will cause the thread to be blocked all the time.
@106umao

logger.error(e.getMessage(), e);
}
}
Expand Down