Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9940 feat: telnet invoke command with context argument. #9974

Merged
merged 1 commit into from Jun 27, 2022

Conversation

stonelion
Copy link
Contributor

@stonelion stonelion commented Apr 26, 2022

What is the purpose of the change

telnet command add context argument.

Brief changelog

  1. command add a new option.
  2. parse this option.
  3. put it into attachment.

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@stonelion stonelion changed the title feat: telnet invoke command with context argument. feat: telnet invoke command with context argument. #9940 Apr 26, 2022
@stonelion stonelion changed the title feat: telnet invoke command with context argument. #9940 #9940 feat: telnet invoke command with context argument. Apr 26, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #9974 (4d270af) into master (3a8e5e6) will decrease coverage by 0.01%.
The diff coverage is 63.15%.

@@             Coverage Diff              @@
##             master    #9974      +/-   ##
============================================
- Coverage     60.92%   60.90%   -0.02%     
+ Complexity      449      447       -2     
============================================
  Files          1100     1100              
  Lines         44557    44565       +8     
  Branches       6486     6488       +2     
============================================
- Hits          27145    27144       -1     
- Misses        14446    14457      +11     
+ Partials       2966     2964       -2     
Impacted Files Coverage Δ
...g/apache/dubbo/qos/legacy/InvokeTelnetHandler.java 68.08% <63.15%> (-2.60%) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) ⬇️
...ng/exchange/support/header/HeartbeatTimerTask.java 68.42% <0.00%> (-5.27%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0.00%> (-4.55%) ⬇️
...apache/dubbo/common/config/ConfigurationUtils.java 67.74% <0.00%> (-3.23%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 88.28% <0.00%> (-0.91%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 89.65% <0.00%> (ø)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 79.72% <0.00%> (+0.34%) ⬆️
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.58% <0.00%> (+0.58%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a8e5e6...4d270af. Read the comment docs.

@stonelion
Copy link
Contributor Author

@AlbumenJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants