Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #9913, rmi protocol supoort group and version #9951

Merged
merged 1 commit into from Sep 8, 2022

Conversation

xielongfei
Copy link

see 9913 bug.
I added support for grouping and versioning in the RmiProtocol doRefer(), createExporter() method. A test method is written in RmiProtocolTest to verify its correctness.

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2022

Codecov Report

Merging #9951 (14d0ea4) into master (3a8e5e6) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #9951      +/-   ##
============================================
- Coverage     60.92%   60.88%   -0.04%     
+ Complexity      449      447       -2     
============================================
  Files          1100     1100              
  Lines         44557    44562       +5     
  Branches       6486     6486              
============================================
- Hits          27145    27131      -14     
- Misses        14446    14466      +20     
+ Partials       2966     2965       -1     
Impacted Files Coverage Δ
...org/apache/dubbo/rpc/protocol/rmi/RmiProtocol.java 0.00% <0.00%> (ø)
...ntext/event/AwaitingNonWebApplicationListener.java 48.48% <0.00%> (-24.25%) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0.00%> (-8.70%) ⬇️
...ng/exchange/support/header/HeartbeatTimerTask.java 68.42% <0.00%> (-5.27%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0.00%> (-4.55%) ⬇️
...apache/dubbo/common/config/ConfigurationUtils.java 67.74% <0.00%> (-3.23%) ⬇️
.../exchange/support/header/HeaderExchangeServer.java 67.61% <0.00%> (-1.91%) ⬇️
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.58% <0.00%> (+0.58%) ⬆️
...ache/dubbo/config/utils/ConfigValidationUtils.java 74.00% <0.00%> (+0.66%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a8e5e6...14d0ea4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants