Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Fix can't authenticate by username and password when use Nacos #9942

Merged
merged 1 commit into from Apr 25, 2022

Conversation

xxxcrel
Copy link
Contributor

@xxxcrel xxxcrel commented Apr 19, 2022

What is the purpose of the change

This PR inspired by issue #9910, when nacos enabled authenticate,
RegistryConfig and ConfigCenterConfig setUsername and setPassword is not working
also fixed in master PR #9941

Brief changelog

org.apache.dubbo.registry.nacos.util.NacosNamingServiceUtils
org.apache.dubbo.configcenter.support.nacos.NacosDynamicConfiguration

@codecov-commenter
Copy link

Codecov Report

Merging #9942 (b398fa8) into 3.0 (6da4c0c) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                3.0    #9942      +/-   ##
============================================
- Coverage     65.70%   65.59%   -0.12%     
  Complexity      319      319              
============================================
  Files          1213     1213              
  Lines         52948    52956       +8     
  Branches       8020     8024       +4     
============================================
- Hits          34792    34735      -57     
- Misses        14363    14411      +48     
- Partials       3793     3810      +17     
Impacted Files Coverage Δ
...enter/support/nacos/NacosDynamicConfiguration.java 23.56% <0.00%> (-0.62%) ⬇️
...o/registry/nacos/util/NacosNamingServiceUtils.java 80.35% <0.00%> (-6.19%) ⬇️
.../remoting/api/SingleProtocolConnectionManager.java 61.53% <0.00%> (-23.08%) ⬇️
...nt/metadata/ServiceInstanceHostPortCustomizer.java 65.78% <0.00%> (-21.06%) ⬇️
...dubbo/common/status/support/LoadStatusChecker.java 46.15% <0.00%> (-15.39%) ⬇️
...bo/rpc/protocol/dubbo/DecodeableRpcInvocation.java 69.44% <0.00%> (-10.19%) ⬇️
...e/dubbo/rpc/protocol/tri/transport/WriteQueue.java 69.04% <0.00%> (-9.53%) ⬇️
...ava/org/apache/dubbo/rpc/proxy/InvocationUtil.java 81.81% <0.00%> (-9.10%) ⬇️
.../common/threadpool/serial/SerializingExecutor.java 70.37% <0.00%> (-7.41%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 87.17% <0.00%> (-5.99%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6da4c0c...b398fa8. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 51c7b15 into apache:3.0 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants