Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - @DubboReference parameters do not put into methodParameters correctly! #9599

Merged
merged 2 commits into from Jan 24, 2022

Conversation

warmonipa
Copy link

@warmonipa warmonipa commented Jan 20, 2022

What is the purpose of the change

@DubboReference parameters can put into methodParameters correctly!

Brief changelog

Rewrite method parameters during turning registry url to consumer url.

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. @DubboReference parameters do not put into methodParameters correctly! #9597
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Member

@wangchengming666 wangchengming666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2022

Codecov Report

Merging #9599 (7f4454d) into master (8240ea2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #9599      +/-   ##
============================================
- Coverage     60.89%   60.88%   -0.02%     
- Complexity      448      449       +1     
============================================
  Files          1100     1100              
  Lines         44520    44521       +1     
  Branches       6478     6478              
============================================
- Hits          27111    27107       -4     
- Misses        14441    14447       +6     
+ Partials       2968     2967       -1     
Impacted Files Coverage Δ
...e/dubbo/registry/integration/DynamicDirectory.java 64.70% <100.00%> (-2.63%) ⬇️
...bo/rpc/cluster/support/FailbackClusterInvoker.java 51.61% <0.00%> (-17.75%) ⬇️
...fig/configcenter/TreePathDynamicConfiguration.java 80.00% <0.00%> (-5.72%) ⬇️
...ubbo/registry/support/AbstractRegistryFactory.java 77.46% <0.00%> (-5.64%) ⬇️
...apache/dubbo/rpc/protocol/injvm/InjvmProtocol.java 74.35% <0.00%> (-5.13%) ⬇️
...pport/merger/DefaultProviderURLMergeProcessor.java 78.26% <0.00%> (-4.35%) ⬇️
.../main/java/org/apache/dubbo/qos/server/Server.java 75.00% <0.00%> (-4.17%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 89.18% <0.00%> (-3.61%) ⬇️
...bo/registry/client/FileSystemServiceDiscovery.java 67.44% <0.00%> (-2.33%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8240ea2...7f4454d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants