Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the problem of wrong number of retries in failback mode #9525

Merged
merged 1 commit into from Jan 23, 2022

Conversation

juzi214032
Copy link
Contributor

What is the purpose of the change

Fix the problem of wrong number of retries in failback mode. When the retries value is zero, the logic in failback mode resets it to the default value of 3, making it impossible to turn off the retry mechanism.

Brief changelog

before

if (retriesConfig <= 0) {
    retriesConfig = DEFAULT_FAILBACK_TIMES;
}

after

if (retriesConfig < 0) {
    retriesConfig = DEFAULT_FAILBACK_TIMES;
}

1. Reset retriesConfig to its default value only when it is zero.
2. Add some retry logs.

Verifying this change

Some test units.

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

When the retries value is zero,
the logic in failback mode resets it to the default value of 3,
making it impossible to turn off the retry mechanism.

Fixes apache#9522
@AlbumenJ
Copy link
Member

please submit a pr to 3.0 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants