Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Fix #9086 NPE #9420

Merged
merged 1 commit into from Dec 16, 2021
Merged

[master] Fix #9086 NPE #9420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/MetadataInfo.java
View file
Open in desktop
Expand Up @@ -339,7 +339,10 @@ public String getMethodParameter(String method, String key, String defaultValue)
}

private String getMethodParameter(String method, String key, Map<String, Map<String, String>> map) {
Map<String, String> keyMap = map.get(method);
Map<String, String> keyMap = null;
if (CollectionUtils.isNotEmptyMap(map)) {
keyMap = map.get(method);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check can avoid NPE from happing by checking before use, however, I don't think it can resolve the root methodParams initialization issue as it has a race condition that needs to be resolved.

String value = null;
if (keyMap != null) {
value = keyMap.get(key);
Expand Down