Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] catch handler.caught() throwable of MultiMessageHandler #8930

Merged
merged 3 commits into from Sep 27, 2021

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Sep 27, 2021

What is the purpose of the change

#8929

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2021

Codecov Report

Merging #8930 (63b6c02) into 3.0 (8e4d9f6) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8930      +/-   ##
============================================
+ Coverage     63.30%   63.32%   +0.01%     
- Complexity      314      315       +1     
============================================
  Files          1182     1182              
  Lines         50199    50202       +3     
  Branches       7511     7511              
============================================
+ Hits          31780    31791      +11     
+ Misses        14945    14939       -6     
+ Partials       3474     3472       -2     
Impacted Files Coverage Δ
.../dubbo/remoting/transport/MultiMessageHandler.java 66.66% <0.00%> (-13.34%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 56.52% <0.00%> (-8.70%) ⬇️
...ng/exchange/support/header/HeartbeatTimerTask.java 68.42% <0.00%> (-5.27%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 76.72% <0.00%> (-1.46%) ⬇️
...n/java/org/apache/dubbo/common/utils/NetUtils.java 68.70% <0.00%> (-0.33%) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 79.72% <0.00%> (+0.34%) ⬆️
...ting/zookeeper/curator/CuratorZookeeperClient.java 72.81% <0.00%> (+1.45%) ⬆️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 88.57% <0.00%> (+1.90%) ⬆️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 71.96% <0.00%> (+2.80%) ⬆️
...he/dubbo/remoting/transport/netty/NettyServer.java 73.68% <0.00%> (+3.50%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e4d9f6...63b6c02. Read the comment docs.

Copy link
Contributor

@changfubai changfubai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit 40d01ee into apache:3.0 Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants