Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] fix NPE in doOverrideIfNecessary #8837

Merged
merged 1 commit into from Sep 21, 2021

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Sep 17, 2021

What is the purpose of the change

fix #8765 on master

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2021

Codecov Report

Merging #8837 (199e397) into master (f8f6995) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8837      +/-   ##
============================================
+ Coverage     61.05%   61.08%   +0.02%     
  Complexity      449      449              
============================================
  Files          1100     1100              
  Lines         44422    44422              
  Branches       6469     6469              
============================================
+ Hits          27124    27137      +13     
+ Misses        14314    14294      -20     
- Partials       2984     2991       +7     
Impacted Files Coverage Δ
...e/dubbo/registry/integration/RegistryProtocol.java 67.17% <0.00%> (+4.86%) ⬆️
...pache/dubbo/registry/support/AbstractRegistry.java 78.88% <0.00%> (-1.49%) ⬇️
...pache/dubbo/registry/support/FailbackRegistry.java 64.05% <0.00%> (-0.93%) ⬇️
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.00% <0.00%> (-0.59%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 80.89% <0.00%> (-0.22%) ⬇️
...mon/src/main/java/org/apache/dubbo/common/URL.java 55.24% <0.00%> (+0.21%) ⬆️
...e/dubbo/remoting/transport/netty4/NettyClient.java 71.01% <0.00%> (+1.44%) ⬆️
.../dubbo/remoting/transport/netty4/NettyChannel.java 64.35% <0.00%> (+1.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8f6995...199e397. Read the comment docs.

Copy link
Contributor

@changfubai changfubai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 15d16f6 into apache:master Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants