Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] fix destroy IllegalStateException and doOverrideIfNecessary NPE #8768

Merged
merged 11 commits into from Sep 20, 2021

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented Sep 10, 2021

What is the purpose of the change

supplement fix #8681

Copy link
Contributor

@changfubai changfubai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2021

Codecov Report

Merging #8768 (3f08380) into 3.0 (afbeaaf) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8768      +/-   ##
============================================
- Coverage     63.80%   63.79%   -0.01%     
  Complexity      314      314              
============================================
  Files          1169     1169              
  Lines         49200    49216      +16     
  Branches       7360     7363       +3     
============================================
+ Hits          31393    31399       +6     
  Misses        14386    14386              
- Partials       3421     3431      +10     
Impacted Files Coverage Δ
...a/org/apache/dubbo/rpc/model/ApplicationModel.java 80.26% <100.00%> (+0.26%) ⬆️
...e/dubbo/registry/integration/RegistryProtocol.java 65.65% <100.00%> (+4.82%) ⬆️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0.00%> (-10.87%) ⬇️
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 61.32% <0.00%> (-3.84%) ⬇️
...spring/context/DubboDeployApplicationListener.java 76.74% <0.00%> (-3.26%) ⬇️
.../registry/zookeeper/ZookeeperServiceDiscovery.java 82.14% <0.00%> (-2.39%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 62.06% <0.00%> (-1.98%) ⬇️
.../exchange/support/header/HeaderExchangeServer.java 66.98% <0.00%> (-1.89%) ⬇️
...che/dubbo/config/deploy/DefaultModuleDeployer.java 63.28% <0.00%> (-1.45%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afbeaaf...3f08380. Read the comment docs.

@zrlw
Copy link
Contributor Author

zrlw commented Sep 17, 2021

#8765

@zrlw zrlw changed the title [3.0] fix destroy IllegalStateException and doOverrideIfNecessary potential NPE [3.0] fix destroy IllegalStateException and doOverrideIfNecessary NPE Sep 18, 2021
@AlbumenJ AlbumenJ merged commit 22dc294 into apache:3.0 Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github构建日志里有很多涉及RegistryProtocol的异常
4 participants