Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the switch to open class check， default is true #8537

Merged
merged 1 commit into from Aug 23, 2021
Merged

add the switch to open class check， default is true #8537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions dubbo-common/src/main/java/org/apache/dubbo/common/constants/CommonConstants.java
View file
Open in desktop
Expand Up @@ -389,6 +389,8 @@ public interface CommonConstants {

String DEFAULT_VERSION = "0.0.0";

String CLASS_DESERIALIZE_OPEN_CHECK = "dubbo.security.serialize.openCheckClass";

String CLASS_DESERIALIZE_BLOCK_ALL = "dubbo.security.serialize.blockAllClassExceptAllow";

String CLASS_DESERIALIZE_ALLOWED_LIST = "dubbo.security.serialize.allowedClassList";
Expand Down
8 changes: 8 additions & 0 deletions dubbo-common/src/main/java/org/apache/dubbo/common/utils/SerializeClassChecker.java
View file
Open in desktop
Expand Up @@ -32,6 +32,7 @@ public class SerializeClassChecker {

private static volatile SerializeClassChecker INSTANCE = null;

private final boolean OPEN_CHECK_CLASS;
private final boolean BLOCK_ALL_CLASS_EXCEPT_ALLOW;
private final Set<String> CLASS_DESERIALIZE_ALLOWED_SET = new ConcurrentHashSet<>();
private final Set<String> CLASS_DESERIALIZE_BLOCKED_SET = new ConcurrentHashSet<>();
Expand All @@ -43,6 +44,9 @@ public class SerializeClassChecker {
private final AtomicLong counter = new AtomicLong(0);

private SerializeClassChecker() {
String openCheckClass = System.getProperty(CommonConstants.CLASS_DESERIALIZE_OPEN_CHECK, "true");
OPEN_CHECK_CLASS = Boolean.parseBoolean(openCheckClass);

String blockAllClassExceptAllow = System.getProperty(CommonConstants.CLASS_DESERIALIZE_BLOCK_ALL, "false");
BLOCK_ALL_CLASS_EXCEPT_ALLOW = Boolean.parseBoolean(blockAllClassExceptAllow);

Expand Down Expand Up @@ -107,6 +111,10 @@ protected static void clearInstance() {
* @param name class name ( all are convert to lower case )
*/
public void validateClass(String name) {
if(!OPEN_CHECK_CLASS){
return;
}

name = name.toLowerCase(Locale.ROOT);
if (CACHE == CLASS_ALLOW_LFU_CACHE.get(name)) {
return;
Expand Down