Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve annotation parameters test #8535

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

kylixs
Copy link
Member

@kylixs kylixs commented Aug 18, 2021

What is the purpose of the change

improve annotation parameters test.

related issue: #8489

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #8535 (d10495f) into 3.0 (a437ae8) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8535      +/-   ##
============================================
+ Coverage     62.95%   62.97%   +0.02%     
+ Complexity      313      312       -1     
============================================
  Files          1116     1116              
  Lines         46725    46725              
  Branches       7031     7031              
============================================
+ Hits          29415    29427      +12     
+ Misses        14057    14040      -17     
- Partials       3253     3258       +5     
Impacted Files Coverage Δ
...dubbo/config/spring/util/DubboAnnotationUtils.java 48.27% <ø> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 60.86% <0.00%> (-6.53%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0.00%> (-4.55%) ⬇️
.../exchange/support/header/HeaderExchangeServer.java 66.98% <0.00%> (-2.84%) ⬇️
.../dubbo/registry/integration/RegistryDirectory.java 46.84% <0.00%> (-0.67%) ⬇️
...vent/listener/ServiceInstancesChangedListener.java 78.10% <0.00%> (+0.49%) ⬆️
...pache/dubbo/remoting/transport/AbstractServer.java 62.85% <0.00%> (+1.42%) ⬆️
.../dubbo/remoting/transport/netty4/NettyChannel.java 66.33% <0.00%> (+1.98%) ⬆️
...va/org/apache/dubbo/registry/RegistryNotifier.java 88.57% <0.00%> (+5.71%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a437ae8...d10495f. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 592c818 into apache:3.0 Aug 23, 2021
@AlbumenJ AlbumenJ added this to the 3.0.3 milestone Aug 23, 2021
@kylixs kylixs deleted the 3.0-improve-annotation-parameters-test branch October 23, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants